Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-16844 Remember whether the user wants the Info Panel #3865

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Jul 12, 2024

-New boolean panelWanted records user preference

-New boolean parameter for closePanel distinguishes manually clicking close box from automatically closing when switching to special view where panel does not belong

-Revise panelShouldBeShown to check panelWanted and getCurrentSpecial

CLDR-16844

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

-New boolean panelWanted records user preference

-New boolean parameter for closePanel distinguishes manually clicking close box from automatically closing when switching to special view where panel does not belong

-Revise panelShouldBeShown to check panelWanted and getCurrentSpecial
@btangmu btangmu self-assigned this Jul 12, 2024
@btangmu btangmu requested a review from srl295 July 12, 2024 17:38
@btangmu btangmu merged commit 49c74ad into unicode-org:main Jul 16, 2024
12 checks passed
@btangmu btangmu deleted the t16844_a branch July 16, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants